Skip to content

Conversation

@Trott
Copy link
Member

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

debugger

Description of change
  • == -> ===
  • use white space in array to improve readability

* `==` -> `===` * use white space in array to improve readability
@TrottTrott added addons Issues and PRs related to native addons. debugger and removed addons Issues and PRs related to native addons. labels Nov 30, 2016
Copy link
Contributor

@cjihrigcjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reformatting of ignored seems like noise to me, but everything else LGTM.

@lpinca
Copy link
Member

Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2016
* `==` -> `===` * use white space in array to improve readability PR-URL: nodejs#9860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
MemberAuthor

Trott commented Dec 5, 2016

Landed in 34a6c85

@TrottTrott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
* `==` -> `===` * use white space in array to improve readability PR-URL: #9860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@Fishrock123Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
* `==` -> `===` * use white space in array to improve readability PR-URL: nodejs#9860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
* `==` -> `===` * use white space in array to improve readability PR-URL: #9860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
* `==` -> `===` * use white space in array to improve readability PR-URL: #9860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
* `==` -> `===` * use white space in array to improve readability PR-URL: #9860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
* `==` -> `===` * use white space in array to improve readability PR-URL: #9860 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 21, 2016
@TrottTrott deleted the refactor-debugger branch January 13, 2022 22:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@lpinca@targos@cjihrig@MylesBorins