Fixed the test with const and strictEqual#9899
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
imyller added the code-and-learn 
Member
Trott commented Dec 1, 2016
Member
gibfahn commented Dec 2, 2016
cjihrig requested changes Dec 3, 2016
| assert.ok(typeofhome==='string'); | ||
| assert.ok(home.indexOf(path.sep)!==-1); | ||
| assert.strictEqual(typeofhome,'string'); |
Contributor
There was a problem hiding this comment.
Why the indentation here? Also, no space before the comma please.
Member
Trott commented Dec 7, 2016
Fixed linting nit and force-pushed. PTAL @cjihrig |
cjihrig approved these changes Dec 7, 2016
Member
jasnell commented Dec 7, 2016
Failure in CI appears to be completely unrelated but still worth noting. |
jasnell pushed a commit that referenced this pull request Dec 7, 2016
PR-URL: #9899 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
jasnell commented Dec 7, 2016
Landed in 1b25214. Thank you for the PR and for participating in the code-and-learn! |
addaleax pushed a commit that referenced this pull request Dec 8, 2016
PR-URL: #9899 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
PR-URL: nodejs#9899 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
PR-URL: #9899 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
PR-URL: #9899 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
PR-URL: #9899 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Fixed the test with const and strictEqual