test: update test to assert require() and es6ify variables#9912
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
mscdex commented Dec 1, 2016
This needs to have a more descriptive commit message and it should start with a |
imyller added the code-and-learn 
DarylThayil changed the title 
Author
DarylThayil commented Dec 1, 2016
updated description @mscdex |
Contributor
@DarylThayil That updated the PR title, but not the actual commit message. |
Author
DarylThayil commented Dec 1, 2016
ahh yes! @mscdex should have got it now thanks |
Member
gibfahn commented Dec 2, 2016
@DarylThayil It's still over 50 chars, maybe something like: |
Member
jasnell commented Dec 5, 2016
* var => const * assert test fixtures
Author
DarylThayil commented Dec 5, 2016
fhinkel approved these changes Dec 6, 2016
Member
fhinkel left a comment
fhinkel left a comment There was a problem hiding this comment.
LGTM. Thanks! Yes, we'll merge it for you :)
jasnell pushed a commit that referenced this pull request Dec 6, 2016
* var => const * assert test fixtures PR-URL: #9912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Member
jasnell commented Dec 6, 2016
Landed in 81661a7. Thank you for the PR and for participating in the code-and-learn! |
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
* var => const * assert test fixtures PR-URL: #9912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
* var => const * assert test fixtures PR-URL: nodejs#9912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
* var => const * assert test fixtures PR-URL: nodejs#9912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
* var => const * assert test fixtures PR-URL: #9912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
* var => const * assert test fixtures PR-URL: #9912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
* var => const * assert test fixtures PR-URL: #9912 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Tests
Description of change
Code and Learn change for test-require-extensions-main.js