test: use strictEqual instead of equal#9930
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
imyller added the code-and-learn 
mscdex added the child_process 
princejwesley approved these changes Dec 1, 2016
Contributor
princejwesley left a comment
princejwesley left a comment There was a problem hiding this comment.
Please change first line of commit message as test: refactor test-child-process-double-pipe
and specify the change description in the next line.
Update test to use strictEqual instead of equal to remove error.
cjihrig approved these changes Dec 4, 2016
addaleax approved these changes Dec 5, 2016
jasnell approved these changes Dec 5, 2016
jasnell pushed a commit that referenced this pull request Dec 5, 2016
Update test to use strictEqual instead of equal to remove error. PR-URL: #9930 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Dec 5, 2016
Landed in a6ab607. thank you for the PR and for participating in the code-and-learn! |
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
Update test to use strictEqual instead of equal to remove error. PR-URL: #9930 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Update test to use strictEqual instead of equal to remove error. PR-URL: nodejs#9930 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Update test to use strictEqual instead of equal to remove error. PR-URL: nodejs#9930 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Update test to use strictEqual instead of equal to remove error. PR-URL: #9930 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Update test to use strictEqual instead of equal to remove error. PR-URL: #9930 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Update test to use strictEqual instead of equal to remove error. PR-URL: #9930 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX)Affected core subsystem(s)
test
Description of change
Updated test to remove error since expectation is to use strictEquals
for tests.