test: clean up repl-reset-event file

[courtnek]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

Description of change

• Change vars to let/const
• Add mustCall
• equal -> strictEqual
• remove timeout

[cjihrig]

Can you line this up with the previous line.

[Trott]

Ping @courtnek: Thanks for the work on this! Can you make the change requested by @cjihrig and push it to this branch?

If you want, you can copy/paste this into the file:

'use strict';constcommon=require('../common');common.globalCheck=false;constassert=require('assert');constrepl=require('repl');// Create a dummy stream that does nothingconstdummy=newcommon.ArrayStream();functiontestReset(cb){constr=repl.start({input: dummy,output: dummy,useGlobal: false});r.context.foo=42;r.on('reset',common.mustCall(function(context){assert(!!context,'REPL did not emit a context with reset event');assert.strictEqual(context,r.context,'REPL emitted incorrect context');assert.strictEqual(context.foo,undefined,'REPL emitted the previous context, and is not using global as context');context.foo=42;cb();}));r.resetContext();}functiontestResetGlobal(){constr=repl.start({input: dummy,output: dummy,useGlobal: true});r.context.foo=42;r.on('reset',common.mustCall(function(context){assert.strictEqual(context.foo,42,'"foo" property is missing from REPL using global as context');}));r.resetContext();}testReset(common.mustCall(testResetGlobal));

[courtnek]

Hey @cjihrig@Trott,

Sorry for the delay!

Yeah @Trott I like breaking up the function args over multiple lines over splitting the string. I amended my commit with the new style.

Let me know if there is anything else I can do.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/5519/

@cjihrig Looks like your comment has been addressed. Looks good to you now?

[Trott]

CI is ✅

[jasnell]

ping @cjihrig

[jasnell]

Landed in e81e031

[Trott]

Thanks for the contribution, @courtnek! 🎉