Using assert.strictEqual instead of equal#9950
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mscdex added domain 
Contributor
mscdex commented Dec 1, 2016
Please follow the commit message guidelines here. |
imyller added the code-and-learn 
jasnell approved these changes Dec 5, 2016
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
Code changes LGTM. Commits need to be squashed and formatted to meet commit guidelines.
cjihrig requested changes Dec 5, 2016
Contributor
There was a problem hiding this comment.
No need for the indent here, or the space before the comma.
Member
Trott commented Dec 21, 2016
Member
Trott commented Dec 21, 2016
Hmmm...actually, it might not even be needed once the merge conflict is done. Let me do that first and see if there's still an issue... |
Member
Trott commented Dec 21, 2016
@cjihrig With the rebase against master, the issue you commented on is now gone. In fact, the change set for this PR is now down to just two lines. Can you confirm that it looks OK to you and update your code review appropriately? |
Member
Trott commented Dec 21, 2016
cjihrig approved these changes Dec 22, 2016
Trott approved these changes Dec 22, 2016
italoacasas approved these changes Dec 22, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 22, 2016
Use assert.strictEqual instead of assert.equal. PR-URL: nodejs#9950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Dec 22, 2016
Landed in dd98649. |
targos pushed a commit that referenced this pull request Dec 26, 2016
Use assert.strictEqual instead of assert.equal. PR-URL: #9950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Dec 26, 2016
Use assert.strictEqual instead of assert.equal. PR-URL: #9950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
Use assert.strictEqual instead of assert.equal. PR-URL: #9950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
Use assert.strictEqual instead of assert.equal. PR-URL: #9950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change