test: change var to const and add mustCall in crypto tests#9954
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
imyller added code-and-learn 
Contributor
mscdex commented Dec 1, 2016
First line of commit is too long, see the commit message guidelines here. |
princejwesley approved these changes Dec 1, 2016
Contributor
princejwesley left a comment
princejwesley left a comment There was a problem hiding this comment.
Commit message is too long. keep it short as per the guideline!
cjihrig requested changes Dec 5, 2016
Contributor
There was a problem hiding this comment.
Looks like an extra space here.
jasnell approved these changes Dec 5, 2016
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM with formatting nits addressed.
Member
Trott commented Dec 22, 2016
Ping @harishtejwani: Can you remove the extra space identified by @cjihrig? |
ContributorAuthor
harishtejwani commented Dec 22, 2016 via email
Sure, sorry will do later this week …Sent from my iPhone On Dec 21, 2016, at 4:15 PM, Rich Trott ***@***.***> wrote: Ping @harishtejwani: Can you remove the extra space identified by @cjihrig? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. |
Trottforce-pushed the test-mustCall-crypto-fix branch from 2c7e030 to d425490CompareMember
Trott commented Dec 23, 2016
@harishtejwani Because it was such a small change (remove one space character), I went ahead and did it for you and force pushed to your branch. @cjihrig Can you update your review if appropriate? Thanks! |
Member
Trott commented Dec 23, 2016
cjihrig approved these changes Dec 24, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 24, 2016
change var to const and add mustCall PR-URL: nodejs#9954 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
Trott commented Dec 24, 2016
Landed in 0ff69b4. |
targos pushed a commit that referenced this pull request Dec 26, 2016
change var to const and add mustCall PR-URL: #9954 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
change var to const and add mustCall PR-URL: #9954 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
change var to const and add mustCall PR-URL: #9954 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
test: change var to const and add mustCall in crypto tests. Did not add mustCall on process exit