test: replace var with const/let and use common.mustCall for cb#9959
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
imyller added the code-and-learn 
Contributor
princejwesley left a comment
princejwesley left a comment There was a problem hiding this comment.
Merge commits as single commit!
outsiderisforce-pushed the code-and-learn-1 branch from 92d4a6e to fff2a4aCompare
ContributorAuthor
outsideris commented Dec 1, 2016
@princejwesley I merged them. |
cjihrig approved these changes Dec 5, 2016
Contributor
There was a problem hiding this comment.
Can you move this line below the hasCrypto check?
jasnell approved these changes Dec 5, 2016
Member
Trott commented Dec 8, 2016
remove process.on('exit') because all callbacks are wrapped by common.mustCall.outsiderisforce-pushed the code-and-learn-1 branch from fff2a4a to 1c38ce2CompareContributorAuthor
outsideris commented Dec 9, 2016
As @cjihrig said, I moved the require statement. |
Member
Trott commented Dec 9, 2016
silverwind approved these changes Dec 16, 2016
Contributor
silverwind commented Dec 16, 2016
Thanks! Landed with slightly trimmed commit message in 4913acd. |
silverwind pushed a commit that referenced this pull request Dec 16, 2016
remove process.on('exit') because all callbacks are wrapped by common.mustCall. PR-URL: #9959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>ContributorAuthor
outsideris commented Dec 17, 2016
@silverwind Thanks! |
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
remove process.on('exit') because all callbacks are wrapped by common.mustCall. PR-URL: #9959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
remove process.on('exit') because all callbacks are wrapped by common.mustCall. PR-URL: #9959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
targos pushed a commit that referenced this pull request Dec 26, 2016
remove process.on('exit') because all callbacks are wrapped by common.mustCall. PR-URL: #9959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
remove process.on('exit') because all callbacks are wrapped by common.mustCall. PR-URL: #9959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
remove process.on('exit') because all callbacks are wrapped by common.mustCall. PR-URL: #9959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
remove process.on('exit') because all callbacks are wrapped by common.mustCall. PR-URL: #9959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
remove process.on('exit') because all callbacks are wrapped by common.mustCall. PR-URL: #9959 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
common.mustCallfor callbacksprocess.on('exit')because all callbacks are wrapped bycommon.mustCall