test: improve the code in test-tls-friendly-message.js#9967
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
imyller added the code-and-learn 
Contributor
mscdex commented Dec 1, 2016
The commit message could be a bit more descriptive. The first line of the commit message should also be <= 50 characters. See the commit message guidelines here. |
Replaces var for const for include modules and implement missing common.mustCall for some anonymous functions
edsadrforce-pushed the tls-friendly-error-message branch from 34b31e0 to ab7c2a0Compare
MemberAuthor
edsadr commented Dec 1, 2016
@mscdex just improved the commit message |
addaleax approved these changes Dec 2, 2016
Member
addaleax commented Dec 2, 2016
Contributor
cjihrig commented Dec 5, 2016
Landed in dc08ced. Thanks! |
cjihrig pushed a commit that referenced this pull request Dec 5, 2016
Replaces var with const and adds common.mustCall(). PR-URL: #9967 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Replaces var with const and adds common.mustCall(). PR-URL: #9967 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Replaces var with const and adds common.mustCall(). PR-URL: nodejs#9967 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Replaces var with const and adds common.mustCall(). PR-URL: nodejs#9967 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Replaces var with const and adds common.mustCall(). PR-URL: #9967 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Replaces var with const and adds common.mustCall(). PR-URL: #9967 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Replaces var with const and adds common.mustCall(). PR-URL: #9967 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This was referenced Jul 1, 2023
This was referenced Jul 8, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
code improvements in
/test/parallel/test-tls-friendly-error-message.jsReplaces var for const and implement some missings common.mustCall