Change var to const or let in test-child-process-ipc.js#9990
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
imyller added the code-and-learn 
Member
imyller commented Dec 1, 2016
@malenesok007 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
mscdex added the child_process ContributorAuthor
malenesok007 commented Dec 1, 2016
Hi I have modify the commit message. Is there something I am missing? Thanks. |
jasnell approved these changes Dec 5, 2016
Member
Trott commented Dec 8, 2016
silverwind suggested changes Dec 9, 2016
Contributor
There was a problem hiding this comment.
Linter error here:
error 'child' is never reassigned. Use 'const' instead prefer-const Member
Trott commented Dec 22, 2016
Ping @malenesok007: Can you change the |
Member
Trott commented Dec 24, 2016
Because it was a straightforward lint fix, I made the change and pushed it to @malenesok007's branch. @silverwind Can you take a look and, if appropriate, update your review? Thanks! |
Member
Trott commented Dec 24, 2016
silverwind approved these changes Dec 24, 2016
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 24, 2016
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: nodejs#9990 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Member
Trott commented Dec 24, 2016
Landed in ff88a5a. |
targos pushed a commit that referenced this pull request Dec 26, 2016
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
Change var to const or let. Change assert.equal() to assert.strictEqual(). PR-URL: #9990 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change