ci: bring back testing on alpine#47
Uh oh!
There was an error while loading. Please reload this page.
Conversation
robertgzr requested review from RaisinTen, dsanders11 and jviotti as code owners
dsanders11 commented Sep 29, 2022
This needs some larger testing refactoring to work - the test binaries are built during |
robertgzrforce-pushed the test-alpine branch 9 times, most recently from da134cc to 05b5ff4Compare
RaisinTen left a comment
RaisinTen left a comment There was a problem hiding this comment.
Shouldn't this purely be a circleci config edit?
the test binaries are built during
build-<os>, so the test binaries from linux won't work ontest-alpine
Why not? When I copy the the dist directory generated in build-linux on my macOS, it does work when I run npm test.
robertgzr commented Oct 4, 2022
@RaisinTen, we're running the test binary: how does that work with a linux binary on macos? |
RaisinTen commented Oct 4, 2022
Ah I see your point, I was referring to the WASM binary that was getting tested, not the Looks like there are some failures that needs addressing? |
robertgzrforce-pushed the test-alpine branch 2 times, most recently from 378cf54 to 8d30425Compare
Signed-off-by: Robert Günzler <[email protected]>
Ref: #31 Signed-off-by: Robert Günzler <[email protected]>
| awaitfs.copy("../src/cli.js","../dist/cli.js"); | ||
| awaitfs.copy("../postject-api.h","../dist/postject-api.h"); | ||
| cd(".."); |
There was a problem hiding this comment.
didn't expect the directory change to persist after exiting the function scope :/ a defer instruction would be useful here
There was a problem hiding this comment.
yea, seems to be a quirk of zx that would feel a little unexpected to folks who are used to writing these using sh
Ref: #31
Signed-off-by: Robert Günzler [email protected]