use AbortSignal.any if possible#3779
Open
+92 −71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tsctxforce-pushed the use-abortsignal-any branch from 5149e0d to c904048Comparetsctx changed the title 
MemberAuthor
tsctx commented Oct 28, 2024
Only available after v23 (nodejs/node@d473606) due to event firing order issues. |
KhafraDev requested changes Oct 28, 2024
Member
There was a problem hiding this comment.
I believe there are a number of memory leaks related to AbortSignal.any.
edit: Yeah, there are.
nodejs/node#54614
nodejs/node#55328
nodejs/node#55354 (which has only made it into v23.1.0 so far)
MemberAuthor
tsctx commented Oct 29, 2024
Let's wait until the fix patch lands on LTS. |
Member
KhafraDev commented Oct 29, 2024
There are two issues without patches yet and then we'll have to manage both the AbortSignal.any path and our own. Is there any benefit in using AbortSignal.any? I see that the issues mentioned that this PR would fix were removed. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbortSignal.any exists from the lowest version currently supported, which simplifies the handling of AbortSignal.
Also, tests that are no longer needed as a result of this have been removed.