Skip to content

Conversation

@wraithgar
Copy link
Member

@wraithgarwraithgar commented Nov 22, 2022

Changed output to display as each check finishes instead of all at once at the end.

Check added: checkBinPath. Checks that the global bin is in your path.

Added grouping to commands.

@wraithgarwraithgar requested a review from a team as a code ownerNovember 22, 2022 20:58
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Nov 22, 2022

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@835.125 ±1.6917.855 ±0.0516.415 ±0.0419.241 ±1.133.034 ±0.082.985 ±0.042.440 ±0.1311.423 ±0.042.441 ±0.054.010 ±0.55
#588832.664 ±1.7717.561 ±0.1716.226 ±0.2519.302 ±1.363.112 ±0.132.986 ±0.012.367 ±0.0611.360 ±0.012.334 ±0.013.883 ±0.71
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@824.932 ±0.1413.922 ±0.0212.715 ±0.2014.044 ±0.232.734 ±0.012.706 ±0.042.443 ±0.038.707 ±0.022.344 ±0.013.812 ±1.02
#588824.532 ±1.3213.722 ±0.0912.709 ±0.0613.609 ±0.122.805 ±0.032.804 ±0.052.354 ±0.038.878 ±0.012.204 ±0.004.346 ±1.86

@wraithgar
Copy link
MemberAuthor

I can edit this to include docs once we've bikeshed the subcommand names.

Copy link
Contributor

@fritzyfritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. We can bikeshed the subcommand name next standup.

@wraithgarwraithgar changed the title Discrete npm doctor commands / add environment checkfeat: discrete npm doctor commandsDec 6, 2022
Usage is driven by actual code, commands are tagged for grouping
nlf
nlf approved these changes Dec 6, 2022
Copy link
Contributor

@nlfnlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless there are objections, i think this makes sense to me. the groupings are named well enough to be intuitive.

@wraithgarwraithgar requested a review from fritzyDecember 6, 2022 20:57
@wraithgar
Copy link
MemberAuthor

Please squash this one when merging.

@lukekarryslukekarrys merged commit cf57ffa into latestDec 7, 2022
@lukekarryslukekarrys deleted the gar/discrete-doctor branch December 7, 2022 19:39
@github-actionsgithub-actionsbot mentioned this pull request Dec 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@wraithgar@npm-cli-bot@fritzy@nlf@lukekarrys