Skip to content

deps: upgrade npm to 9.2.0#45780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Dec 9, 2022
Merged

deps: upgrade npm to 9.2.0 #45780

nodejs-github-bot merged 1 commit into from
Dec 9, 2022

Conversation

@npm-cli-bot
Copy link
Contributor

@npm-cli-botnpm-cli-bot commented Dec 7, 2022

9.2.0 (2022-12-07)

Features

Bug Fixes

Dependencies

@nodejs-github-botnodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Dec 7, 2022
@github-actions
Copy link
Contributor

github-actionsbot commented Dec 7, 2022

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2022
@github-actionsgithub-actionsbot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48351/

@targos
Copy link
Member

targos commented Dec 8, 2022

If I counted correctly, this introduces 8 identical copies of minipass@v3. Is that expected?

@lukekarrys
Copy link
Member

lukekarrys commented Dec 8, 2022

If I counted correctly, this introduces 8 identical copies of minipass@v3. Is that expected?

@targos yes that is correct. We updated to minipass@4 across all of our dependencies, so that version is now deduped to the top of node_modules but that leaves 8 other dependencies still using minipass@3. We have a plan to send PRs to those dependencies to update to minipass@4 (which should be an easy update) to once again dedupe to a single version of minipass hopefully within the next couple releases. I did measure the release and and this increased the bundle size about 14kb which is the main tradeoff with our approach.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/48362/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2022
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2022
@nodejs-github-botnodejs-github-bot merged commit 7d80ca3 into nodejs:mainDec 9, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2022

Landed in 7d80ca3

@internalsystemerrorinternalsystemerror mentioned this pull request Dec 10, 2022
Closed
1 task
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Dec 12, 2022
@npm-cli-bot@ErickWendel
deps: upgrade npm to 9.2.0
e9ca5d3
PR-URL: nodejs#45780 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit that referenced this pull request Dec 12, 2022
@npm-cli-bot@targos
deps: upgrade npm to 9.2.0
52c4e20
PR-URL: #45780 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Dec 12, 2022
@targos
2022-12-13, Version 19.3.0 (Current)
5859103
Notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 deps: * upgrade npm to 9.2.0 (npm team) #45780 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael Gonzaga to the TSC (Michael Dawson) #45691 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * remove trustcor root ca certificates (Ben Noordhuis) #45776 PR-URL: #45831
targos added a commit that referenced this pull request Dec 12, 2022
@targos
2022-12-13, Version 19.3.0 (Current)
4d316b8
Notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 deps: * upgrade npm to 9.2.0 (npm team) #45780 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael Gonzaga to the TSC (Michael Dawson) #45691 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * remove trustcor root ca certificates (Ben Noordhuis) #45776 PR-URL: #45831
@targostargos mentioned this pull request Dec 12, 2022
Merged
@BethGriggsBethGriggs added the baking-for-lts PRs that need to wait before landing in a LTS release. label Dec 12, 2022
targos added a commit that referenced this pull request Dec 13, 2022
@targos
2022-12-13, Version 19.3.0 (Current)
ced2829
Notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 deps: * upgrade npm to 9.3.0 (npm team) #45780 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael Gonzaga to the TSC (Michael Dawson) #45691 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * remove trustcor root ca certificates (Ben Noordhuis) #45776 PR-URL: #45831
targos pushed a commit that referenced this pull request Dec 13, 2022
@npm-cli-bot@targos
deps: upgrade npm to 9.2.0
75dbce9
PR-URL: #45780 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Dec 13, 2022
@targos
2022-12-13, Version 19.3.0 (Current)
d98cf20
Notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 deps: * upgrade npm to 9.3.0 (npm team) #45780 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael Gonzaga to the TSC (Michael Dawson) #45691 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * remove trustcor root ca certificates (Ben Noordhuis) #45776 PR-URL: #45831
targos added a commit that referenced this pull request Dec 14, 2022
@targos
2022-12-14, Version 19.3.0 (Current)
84aabcf
Notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 deps: * upgrade npm to 9.2.0 (npm team) #45780 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael Gonzaga to the TSC (Michael Dawson) #45691 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * remove trustcor root ca certificates (Ben Noordhuis) #45776 PR-URL: #45831
targos added a commit that referenced this pull request Dec 14, 2022
@targos
2022-12-14, Version 19.3.0 (Current)
b4f8186
Notable changes: build: * disable v8 snapshot compression by default (Joyee Cheung) #45716 deps: * upgrade npm to 9.2.0 (npm team) #45780 doc: * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697 * add Rafael Gonzaga to the TSC (Michael Dawson) #45691 net: * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731 src: * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639 test_runner: * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792 * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792 tls: * remove trustcor root ca certificates (Ben Noordhuis) #45776 PR-URL: #45831
@derrabusderrabus mentioned this pull request Dec 14, 2022
Closed
@ruyadornoruyadorno mentioned this pull request Dec 16, 2022
Merged
@ruyadorno
Copy link
Member

ruyadorno commented Dec 16, 2022

Let's keep track of the dont-land labels until the npm9 update is ready to land on v18.x, ref: #45693 (comment)

@lukekarrys
Copy link
Member

lukekarrys commented Dec 16, 2022

@ruyadorno if it's helpful i can set our release bot to open PRs with those two dont-land labels for now

Trott pushed a commit to Trott/io.js that referenced this pull request Jan 17, 2023
@npm-cli-bot@Trott
deps: upgrade npm to 9.2.0
5648ed1
PR-URL: nodejs#45780 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@TrottTrott mentioned this pull request Jan 17, 2023
Closed
juanarbol pushed a commit that referenced this pull request Jan 22, 2023
@npm-cli-bot@juanarbol
deps: upgrade npm to 9.2.0
7599b91
PR-URL: #45780 Backport-PR-URL: #46230 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
@juanarboljuanarbol mentioned this pull request Jan 28, 2023
Merged
@richardlaurichardlau removed the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2024
@wraithgarwraithgar deleted the npm-v9.2.0 branch June 26, 2025 15:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@anonriganonriganonrig approved these changes

@cjihrigcjihrigcjihrig approved these changes

@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@npm-cli-bot@nodejs-github-bot@targos@lukekarrys@ruyadorno@lpinca@anonrig@cjihrig@VoltrexKeyva@MylesBorins@richardlau@BethGriggs