Skip to content

Conversation

@ljharb
Copy link
Contributor

What / Why

npm in node 13 says node 13 is unsupported.

I'll update npm in node after this is released; hopefully ASAP as node 13 released today.

@ljharbljharb requested a review from a team as a code ownerOctober 22, 2019 16:47
@isaacsisaacs added the semver:patch semver patch level for changes label Oct 22, 2019
@isaacs
Copy link
Contributor

isaacs commented Oct 22, 2019

Note to @npm/cli-team: we can make this file a lot simpler in npm v7 when we upgrade to a version of semver with the includePrereleases option.

@ljharb
Copy link
ContributorAuthor

Why would that option matter? node 13 could probably have been added prior to its release, it just might not have been counted as "supported" then?

@ljharb
Copy link
ContributorAuthor

yay, tests passed! how soon might this be able to get into a released version of npm?

@MylesBorins
Copy link
Contributor

as soon as this lands on master I can make a backport to node.js core so we can get this sorted in advance of updating npm

@Nothing-Works
Copy link

Nothing-Works commented Oct 23, 2019

1 pending reviewer npm/cli-team.lol what does this mean?

MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Oct 23, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: nodejs#30066
MylesBorins pushed a commit to nodejs/node that referenced this pull request Oct 23, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this pull request Oct 23, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins
Copy link
Contributor

We've landed the patch in Node.js core and are planning a release for later today

PR for 13.0.1 opened nodejs/node#30081

@ruyadorno
Copy link
Contributor

thanks @ljharb and @MylesBorins 🎉

we'll make sure to include it in the planned upcoming release, seeing that the patch already landed on node we're going to stick to our regular schedule 😊

@MylesBorins
Copy link
Contributor

MylesBorins commented Oct 23, 2019 via email

@darcyclarkedarcyclarke mentioned this pull request Oct 24, 2019
2 tasks
@Remzi1993
Copy link

@darcyclarke Could somebody merged this PR? It's still an annoying warning and I completely agree with @isaacs

@mikemimik
Copy link
Contributor

Hello Everyone,

This update is slotted to be included in a release we are putting out next week, 6.12.1, on Tuesday October 29th, 2019. Until then, unfortunately you're going to see the warning message if you install npm outside of what's shipped with the latest node patch.

@mikemimikmikemimik self-assigned this Oct 24, 2019
@ljharbljharb deleted the node_13 branch October 29, 2019 17:26
targos pushed a commit to nodejs/node that referenced this pull request Nov 8, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Nov 10, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Nov 11, 2019
This should keep the npm warning at bay until it is patched upstream. Refs: npm/cli#269 Refs: #30066 PR-URL: #30079 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@ljharb@isaacs@MylesBorins@Nothing-Works@ruyadorno@Remzi1993@mikemimik@darcyclarke