test: fix git configs for git 2.23 and above#456
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
claudiahdz added semver:patch 
mikemimik approved these changes Nov 12, 2019
lib/install/inflate-shrinkwrap.js Outdated
| }else{ | ||
| matchRegTarball=newRegExp(`^${registry}(.*)?/-/\\1-(.*)[.]tgz$`) | ||
| } | ||
| if(!tb)return |
ContributorAuthor
There was a problem hiding this comment.
That seems... unrelated to this commit. Must be something I was testing out? I'll back it out.
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacsClose: #456 Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacsClose: #456 Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacsClose: #456 Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacsClose: #456 Reviewed-by: @claudiahdz
claudiahdz pushed a commit that referenced this pull request Nov 13, 2019
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing. PR-URL: #456 Credit: @isaacsClose: #456 Reviewed-by: @claudiahdz
mikemimik suggested changes Nov 14, 2019
Contributor
mikemimik left a comment
mikemimik left a comment There was a problem hiding this comment.
Small change needs to be backed out. Otherwise LGTM!
Config values are now case-sensitive, so `commit.gpgsign=false` was doing nothing.
isaacsforce-pushed the isaacs/fix-test-git-configs branch from c4a61e6 to 653bd29Compare
ContributorAuthor
isaacs commented Nov 14, 2019
Updated. |
Merged
This was referenced Nov 27, 2019
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This was referenced Jan 17, 2020
This was referenced Feb 25, 2020
This was referenced Mar 10, 2020
This was referenced Mar 19, 2020
This was referenced Mar 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config values are now case-sensitive, so
commit.gpgsign=falsewasdoing nothing.
What / Why
References