- Notifications
You must be signed in to change notification settings - Fork 4k
deps: @npmcli/[email protected]#4639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
e6df61b to 58e8a61Comparenpm-robot commented Mar 30, 2022 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
no statistically significant performance changes detected timing results
|
752a2c0 to a419ca7Compare- add some basic tests for docs - make dockhand script work on windows - cleanup main CI to match template-oss - add a git status check for cli ci tests - use resetdeps for ci steps
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
wraithgar left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing ci-docs to not use a matrix can be a future template-oss fix.
lukekarrys commented Mar 30, 2022
template-oss does support this, which i just pushed a fixup to do. i left the platform matrix in there because i fixed a windows bug with the doc creation script. |
| - run: node ./bin/npm-cli.js run smoke-tests --ignore-scripts | ||
| - name: git status | ||
| if: matrix.platform.os != 'windows-latest' | ||
| run: node scripts/git-dirty.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to highlight that I could not get the git-dirty check to work on windows. I'm ok with that for now, but this might lead to problems for external contributors on windows.
Uh oh!
There was an error while loading. Please reload this page.