Skip to content

Conversation

@lukekarrys
Copy link
Contributor

@lukekarryslukekarrys commented Mar 29, 2022

  • add some basic tests for docs
  • make dockhand script work on windows
  • cleanup main CI to match template-oss
  • add a git status check for cli ci tests
  • use resetdeps for ci steps

@lukekarryslukekarrys requested a review from a team as a code ownerMarch 29, 2022 23:43
@lukekarryslukekarrysforce-pushed the lk/ci-cleanup branch 3 times, most recently from e6df61b to 58e8a61CompareMarch 30, 2022 00:01
@npm-robot
Copy link
Contributor

npm-robot commented Mar 30, 2022

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@854.267 ±5.7131.796 ±0.3829.192 ±15.0021.544 ±0.503.223 ±0.013.209 ±0.082.625 ±0.1112.377 ±0.172.589 ±0.023.672 ±0.03
#463954.776 ±5.5132.335 ±0.1228.393 ±12.9422.066 ±0.213.289 ±0.023.249 ±0.022.622 ±0.1012.621 ±0.062.644 ±0.003.889 ±0.13
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@838.656 ±4.1625.012 ±0.0714.116 ±0.0714.952 ±0.092.972 ±0.032.932 ±0.012.600 ±0.059.220 ±0.072.414 ±0.033.330 ±0.04
#463940.905 ±0.5725.540 ±0.1114.220 ±0.2015.418 ±0.342.976 ±0.042.950 ±0.052.631 ±0.019.280 ±0.132.479 ±0.033.394 ±0.09

@lukekarryslukekarrysforce-pushed the lk/ci-cleanup branch 14 times, most recently from 752a2c0 to a419ca7CompareMarch 30, 2022 07:14
@lukekarryslukekarrys changed the title chore: @npmcli/[email protected]deps: @npmcli/[email protected]Mar 30, 2022
- add some basic tests for docs - make dockhand script work on windows - cleanup main CI to match template-oss - add a git status check for cli ci tests - use resetdeps for ci steps
Copy link
Member

@wraithgarwraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing ci-docs to not use a matrix can be a future template-oss fix.

@lukekarrys
Copy link
ContributorAuthor

Fixing ci-docs to not use a matrix can be a future template-oss fix.

template-oss does support this, which i just pushed a fixup to do. i left the platform matrix in there because i fixed a windows bug with the doc creation script.

- run: node ./bin/npm-cli.js run smoke-tests --ignore-scripts
- name: git status
if: matrix.platform.os != 'windows-latest'
run: node scripts/git-dirty.js
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to highlight that I could not get the git-dirty check to work on windows. I'm ok with that for now, but this might lead to problems for external contributors on windows.

@github-actionsgithub-actionsbot mentioned this pull request Aug 31, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lukekarrys@npm-robot@wraithgar