Skip to content

Conversation

@wraithgar
Copy link
Member

It should happen whenever we read a manifest anyways.

Tests were also rewritten to be real.

It should happen whenever we read a manifest anyways. Tests were also rewritten to be real.
@wraithgarwraithgar requested a review from a team as a code ownerApril 19, 2022 18:29
@npm-robot
Copy link
Contributor

found 1 benchmarks with statistically significant performance regressions

  • app-large: clean
timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@846.873 ±0.6727.629 ±0.6816.032 ±0.0718.151 ±0.582.750 ±0.022.762 ±0.022.211 ±0.0210.505 ±0.022.204 ±0.013.234 ±0.04
#477555.642 ±0.5527.421 ±0.1225.838 ±13.7718.341 ±0.372.810 ±0.002.784 ±0.012.213 ±0.0110.541 ±0.042.255 ±0.033.290 ±0.14
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@834.219 ±0.9321.288 ±0.0711.975 ±0.0712.737 ±0.132.551 ±0.012.501 ±0.002.226 ±0.007.894 ±0.052.089 ±0.022.894 ±0.10
#477536.757 ±0.4721.450 ±0.0012.063 ±0.1112.912 ±0.142.528 ±0.022.529 ±0.002.252 ±0.017.867 ±0.052.108 ±0.002.854 ±0.01

@lukekarryslukekarrys merged commit ced0acf into latestApr 19, 2022
@lukekarryslukekarrys deleted the gar/publish-tests branch April 19, 2022 23:25
@ruyadornoruyadorno mentioned this pull request Apr 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@wraithgar@npm-robot@ruyadorno@lukekarrys