Skip to content

Conversation

@lukekarrys
Copy link
Contributor

This also changes all the log messages about not being able to create
initial directories and files to log.verbose since we know run those
commands on init. There are a lot of valid reasons why those might fail,
and we don't want to show a warning for them every time.

Fixes: #4769
Fixes: #4838
Fixes: #4996

@lukekarryslukekarrys requested a review from a team as a code ownerJuly 20, 2022 14:30
@lukekarryslukekarrys marked this pull request as draft July 20, 2022 14:44
@lukekarrys
Copy link
ContributorAuthor

Need to add a test for this, obviously. 😶‍🌫️

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Jul 20, 2022

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@842.893 ±7.2117.217 ±0.3015.602 ±0.2119.056 ±2.302.571 ±0.122.638 ±0.072.072 ±0.0210.832 ±0.372.065 ±0.073.434 ±0.48
#519745.685 ±0.8217.918 ±0.1215.719 ±0.0419.138 ±1.182.689 ±0.032.607 ±0.022.131 ±0.0510.915 ±0.232.146 ±0.013.368 ±0.35
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@827.559 ±0.8813.271 ±0.1011.660 ±0.3413.051 ±0.492.414 ±0.112.397 ±0.082.164 ±0.007.922 ±0.162.017 ±0.042.905 ±0.02
#519727.391 ±1.1513.307 ±0.2211.742 ±0.2312.873 ±0.492.378 ±0.072.461 ±0.032.162 ±0.068.051 ±0.242.048 ±0.042.820 ±0.01

@lukekarryslukekarrys marked this pull request as ready for review July 20, 2022 18:37
@lukekarryslukekarrysforce-pushed the lk/readonly branch 2 times, most recently from a3733a9 to 44c060cCompareJuly 20, 2022 20:24
@lukekarryslukekarrysforce-pushed the lk/readonly branch 2 times, most recently from 1cac26a to be3afd1CompareJuly 20, 2022 21:15
This also changes all the log messages about not being able to create initial directories and files to `log.verbose` since we know run those commands on init. There are a lot of valid reasons why those might fail, and we don't want to show a warning for them every time. Fixes: #4769Fixes: #4838Fixes: #4996
@lukekarryslukekarrys merged commit 9905d0e into latestJul 21, 2022
@lukekarryslukekarrys deleted the lk/readonly branch July 21, 2022 16:40
@vojty
Copy link

Could you please release a new version with this?

@wraithgar
Copy link
Member

@vojty releases happen weekly on Wednesday. https://github.com/npm/cli/wiki/Release-Process-(v8)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants

@lukekarrys@npm-cli-bot@vojty@wraithgar