Skip to content

Conversation

@XhmikosR
Copy link
Contributor

Should speed things up a bit.

@XhmikosRXhmikosR requested a review from a team as a code ownerDecember 16, 2019 14:50
@darcyclarkedarcyclarke added this to the OSS - Sprint 1 milestone Dec 17, 2019
@mikemimikmikemimik self-assigned this Dec 17, 2019
@mikemimikmikemimik added Community Enhancement new feature or improvement semver:patch semver patch level for changes labels Dec 20, 2019
Copy link
Contributor

@mikemimikmikemimik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to the ci.yml file. The change doesn't need to be reflected in benchmark.yml because we're not using the repo really.

Note to future selves (@npm/cli-team): might be worth removing that git checkout from the yaml.

steps:
# Checkout the npm/cli repo
- uses: actions/checkout@v1
- uses: actions/checkout@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fetch depth defaults to 1 with the new version of actions/checkout. Ordinarily I don't think this would matter, but we've seen some weirdness with depth: 1 checkouts, and I'd rather avoid this for now. We can always adjust this later in the future.

Suggested change
- uses: actions/checkout@v2
- uses: actions/checkout@v2
with:
fetch-depth: 0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs on actions/checkout

# Number of commits to fetch. 0 indicates all history. # Default: 1 fetch-depth: '' 

@XhmikosR
Copy link
ContributorAuthor

I don't agree you need this, unless it causes problems, which it shouldn't.

@XhmikosR
Copy link
ContributorAuthor

To elaborate more, the whole point of this patch is to make use of the new defaults which includes depth 1, which in turn speeds things up. So, unless this causes a problem, there's no reason to proactively change the defaults.

@mikemimik
Copy link
Contributor

We'll validate the changes don't break things on our release branch, and if they don't we'll pull the changes in :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancementnew feature or improvementsemver:patchsemver patch level for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@XhmikosR@mikemimik@darcyclarke