Skip to content

Conversation

@MylesBorins
Copy link
Contributor

Originally auth-type=web would gracefully fallback to auth-type=legacy if a registry had not yet implemented web. This brings back that behavior.

@MylesBorinsMylesBorins requested a review from a team as a code ownerFebruary 10, 2023 20:40
@MylesBorinsMylesBorins requested review from nlf and removed request for a teamFebruary 10, 2023 20:40
@MylesBorinsMylesBorinsforce-pushed the graceful-auth-type branch 2 times, most recently from 763f525 to 110d753CompareFebruary 10, 2023 20:45
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Feb 10, 2023

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@836.412 ±2.5718.148 ±0.1216.587 ±0.0519.094 ±0.733.035 ±0.063.010 ±0.002.381 ±0.0211.574 ±0.042.408 ±0.043.576 ±0.11
#615838.084 ±2.7017.827 ±0.0616.562 ±0.0519.341 ±0.873.041 ±0.013.004 ±0.012.348 ±0.0011.630 ±0.052.351 ±0.013.834 ±0.55
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
npm@825.462 ±1.4814.103 ±0.0612.867 ±0.0213.778 ±0.052.711 ±0.032.733 ±0.042.437 ±0.048.846 ±0.002.270 ±0.013.187 ±0.05
#615826.328 ±2.3314.444 ±0.4512.979 ±0.0313.827 ±0.222.758 ±0.032.809 ±0.082.332 ±0.018.919 ±0.032.210 ±0.053.181 ±0.01

@Ibrahim11a

This comment was marked as spam.

Originally `auth-type=web` would gracefully fallback to `auth-type=legacy` if a registry had not yet implemented web. This brings back that behavior.
@wraithgarwraithgar changed the title auth-type: gracefully fallback from webfix: gracefully fallback from auth-type=webFeb 13, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@MylesBorins@npm-cli-bot@Ibrahim11a@lukekarrys@wraithgar