Skip to content

Conversation

@wraithgar
Copy link
Member

This PR is a series of commits that moves npm itself to use the
package.json parsing logic that was moved from read-package-json and
read-package-json-fast into @npmcli/package-json

It ends with the removal of the first two packages as direct dependents
of the cli. A bit more work needs to be done to remove their usage
elsewhere.

Some commands have tests that mock the library that parses package.json and will need to be fixed before we can move them over
npm itself doesn't use it anymore in favor of @npmcli/package-json#prepare
@wraithgarwraithgar requested a review from a team as a code ownerMay 18, 2023 20:39
@wraithgarwraithgar self-assigned this May 18, 2023
npm itself doesn't use it anymore in favor of @npmcli/package-json#normalize
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 18, 2023

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
show-versionrun-script
npm@951.479 ±4.4623.498 ±0.0222.758 ±0.0925.432 ±0.603.513 ±0.033.550 ±0.073.118 ±0.0115.935 ±0.142.949 ±0.034.448 ±0.010.476 ±0.010.506 ±0.01
#647254.219 ±3.2624.043 ±0.3425.127 ±2.1426.204 ±0.403.634 ±0.143.609 ±0.103.163 ±0.0716.443 ±0.413.037 ±0.064.672 ±0.410.466 ±0.000.530 ±0.01
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
show-versionrun-script
npm@936.310 ±0.8717.862 ±0.2017.379 ±0.1118.797 ±0.523.207 ±0.023.212 ±0.023.063 ±0.0611.680 ±0.022.841 ±0.023.948 ±0.010.449 ±0.010.489 ±0.01
#647237.130 ±1.7818.182 ±0.1517.640 ±0.0918.676 ±0.673.223 ±0.003.292 ±0.023.102 ±0.0611.935 ±0.072.927 ±0.033.991 ±0.000.463 ±0.010.525 ±0.01

@wraithgarwraithgar merged commit fc52ca8 into latestMay 22, 2023
@wraithgarwraithgar deleted the gar/package-json branch May 22, 2023 15:48
@github-actionsgithub-actionsbot mentioned this pull request May 22, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@npm-cli-bot@lukekarrys