Skip to content

Conversation

@wraithgar
Copy link
Member

@wraithgarwraithgar commented Jun 19, 2023

They don't currently have any so that code would never have mattered

cf https://nodejs.org/download/release/

@wraithgarwraithgar requested a review from a team as a code ownerJune 19, 2023 20:07
@wraithgar
Copy link
MemberAuthor

Gonna have to get clever in the test fixture

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Jun 19, 2023

no statistically significant performance changes detected

timing results
app-largecleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
show-versionrun-script
npm@935.080 ±2.3819.409 ±0.0519.039 ±0.0321.248 ±0.093.102 ±0.033.092 ±0.032.661 ±0.0712.900 ±0.032.577 ±0.043.849 ±0.160.434 ±0.010.473 ±0.01
#657436.029 ±2.9119.850 ±0.0619.220 ±0.2021.622 ±0.143.071 ±0.013.165 ±0.032.631 ±0.0013.195 ±0.122.591 ±0.013.754 ±0.110.455 ±0.010.504 ±0.01
app-mediumcleanlock-onlycache-onlycache-only
peer-deps
modules-onlyno-lockno-cacheno-modulesno-cleanno-clean
audit
show-versionrun-script
npm@926.570 ±1.4815.170 ±0.0414.745 ±0.2415.886 ±0.092.779 ±0.052.797 ±0.012.522 ±0.089.800 ±0.282.395 ±0.023.426 ±0.120.426 ±0.000.475 ±0.00
#657426.162 ±1.4815.339 ±0.1114.850 ±0.0516.162 ±0.162.812 ±0.002.874 ±0.032.561 ±0.0410.165 ±0.102.432 ±0.013.399 ±0.000.447 ±0.010.510 ±0.01

@wraithgar
Copy link
MemberAuthor

https://nodejs.org/download/release/

Do we even need the flag at all?

@lukekarrys
Copy link
Contributor

https://nodejs.org/download/release/

Do we even need the flag at all?

At the risk of prematurely optimizing, if Node ever did ship a prerelease we would want that flag (and the template-oss PR). So I think for the sake of having the code match our intent (even if it's not currently possible), we should land both PRs.

They don't currently have any so that code would never have mattered cf https://nodejs.org/download/release/
@wraithgarwraithgarforce-pushed the gar/node-version-prerelease branch from 0b8902e to c420756CompareJune 20, 2023 16:47
@wraithgarwraithgar changed the title fix: use includePrerelease flag when checking node versionfix: ignore node prereleases in npm engines checkJun 20, 2023
@wraithgarwraithgar merged commit 939a188 into latestJun 20, 2023
@wraithgarwraithgar deleted the gar/node-version-prerelease branch June 20, 2023 17:00
@github-actionsgithub-actionsbot mentioned this pull request Jun 20, 2023
lukekarrys pushed a commit that referenced this pull request Jun 20, 2023
They don't currently have any so that code would never have mattered cf https://nodejs.org/download/release/
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar@npm-cli-bot@lukekarrys