feat: Add on_stream to agents as tools#2169
Open
+485 −19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
ihower commented Dec 11, 2025
rm-openai approved these changes Dec 11, 2025
| event: StreamEvent | ||
| """The streaming event from the nested agent run.""" | ||
| agent_name: str |
Collaborator
There was a problem hiding this comment.
instead of agent_name, why not pass the Agent object?
MemberAuthor
There was a problem hiding this comment.
yeah this is true. i will revisit the properties in this object
Comment on lines +463 to +465
| maybe_result=on_stream(payload) | ||
| ifinspect.isawaitable(maybe_result): | ||
| awaitmaybe_result |
Collaborator
There was a problem hiding this comment.
this can be kinda bad since on_stream will block you from going to the next event. fine for now, but we should consider a queue based pattern where we write to a queue from here and the consumer reads from the queue, and we aren't blocking
MemberAuthor
There was a problem hiding this comment.
good call; actually i made these executions async in the TS SDK. so will make this more efficient and consistent.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature equivalent to openai/openai-agents-js#749