Remove reduntant client type check

[steven10a]

Removes unneeded check that the client is OpenAI. This is handled by directly trying the moderation endpoint, if it doesn't exist we create a fallback client

• Fixes a potential bug that was identified in the TS version. The isinstance check is fragile and if it fails to match will cause us to incorrectly set client=None

[Copilot]

Pull Request Overview

This PR simplifies the client extraction logic in the moderation function by removing redundant type checking. The original code checked if the context's guardrail_llm attribute was specifically an AsyncOpenAI instance before using it, but this check is unnecessary since the code later handles API incompatibilities gracefully.

• Simplified client extraction from context by removing unnecessary type check
• Reduced lines of code from 7 to 2 while maintaining the same functionality

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/guardrails/checks/text/moderation.py:36

• Missing import for sync OpenAI class. Line 190 uses isinstance(client, AsyncOpenAI) to detect async clients, implying sync clients are supported, but the sync OpenAI class is not imported. This will cause the code to work accidentally (since non-AsyncOpenAI clients will be treated as sync), but type checking will fail and the code is not explicit about its dependencies. Add OpenAI to the import: from openai import AsyncOpenAI, NotFoundError, OpenAI

from openai import AsyncOpenAI, NotFoundError 

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The client type detection assumes any non-AsyncOpenAI client is synchronous, which may not be accurate for Azure clients or other variants. Consider using a more explicit check like hasattr(client.moderations.create, '__call__') and not inspect.iscoroutinefunction(client.moderations.create) similar to the pattern in llm_base.py (line 231), or import and check against specific sync client types (OpenAI, AzureOpenAI).

[steven10a]

WAI. Only OpenAI clients are valid for moderation so we will catch the other types and fallback to generating an OAI client.

[gabor-openai]

TY