bugfix: lua panic handling in ngx.socket.tcp#2376
Open
+46 −35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pracj3amforce-pushed the pracj3am/socket-tcp-panic branch 3 times, most recently from 94801d8 to 98dc89aCompareIf luaL_pushresult() encounters a buffer larger than 2GB, it triggers a Lua panic. This panic is handled by ngx_http_lua_atpanic(), which performs a longjmp() back to the last setjmp() call point (e.g., ngx_http_lua_log_by_chunk()), potentially causing a SEGFAULT or ABORT signal if stack protection is enabled. The fix sets the handler that manages Lua panics directly within ngx_http_lua_socket_push_input_data().
pracj3amforce-pushed the pracj3am/socket-tcp-panic branch from 98dc89a to 4dd7974CompareSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
luaL_pushresult()encounters a buffer larger than 2GB, it triggers a Lua panic. This panic is handled byngx_http_lua_atpanic(), which performs alongjmp()back to the lastsetjmp()call point (e.g.,ngx_http_lua_log_by_chunk()), potentially causing a SEGFAULT or ABORT signal if stack protection is enabled.The fix sets the handler that manages Lua panics directly within
ngx_http_lua_socket_push_input_data().I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.