Skip to content

[FSSDK-8707] feat(metrics): Adds support for prometheus#348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pulak-opti merged 13 commits into from
Jun 6, 2023
Merged

[FSSDK-8707] feat(metrics): Adds support for prometheus #348

pulak-opti merged 13 commits into from
Jun 6, 2023

Conversation

@yasirfolio3
Copy link
Contributor

@yasirfolio3yasirfolio3 commented Dec 8, 2022•
edited
Loading

Summary

  • Adds support for prometheus in metrics. OPTIMIZELY_ADMIN_METRICSTYPE env variable can be used to switch between expvar and prometheus. Default value is expvar.

Tests

  • Added unit tests.
  • All previous tests should pass.

@yasirfolio3yasirfolio3 changed the title feat(metrics): Added support for prometheusfeat(metrics): Adds support for prometheusDec 9, 2022
@russell-loube-optimizelyrussell-loube-optimizely changed the title feat(metrics): Adds support for prometheus[FSSDK-8707] feat(metrics): Adds support for prometheusMay 30, 2023
prisma-cloud-devsecops[bot]
prisma-cloud-devsecopsbot reviewed Jun 1, 2023
View reviewed changes
Copy link

@prisma-cloud-devsecopsprisma-cloud-devsecopsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

@pulak-optipulak-opti marked this pull request as ready for review June 2, 2023 18:16
@pulak-optipulak-opti requested review from Mat001 and jaeoptJune 2, 2023 18:24
Mat001
Mat001 requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@Mat001Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not an expert on Prometheus. A few license year comments

Mat001
Mat001 requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@Mat001Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not an expert on Prometheus. A few license year comments

@pulak-optipulak-opti requested a review from Mat001June 5, 2023 17:32
Mat001
Mat001 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@Mat001Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good now

@pulak-optipulak-opti merged commit bd0039f into masterJun 6, 2023
@pulak-optipulak-opti deleted the yasir/prometheus branch June 6, 2023 14:03
@pulak-optipulak-opti mentioned this pull request Jun 8, 2023
Closed
pulak-opti added a commit that referenced this pull request Nov 2, 2023
@yasirfolio3@msohailhussain@pulak-opti
[FSSDK-8707] feat(metrics): Adds support for prometheus (#348)
97997ff
* Added support for prometheus. * Added unit tests. * Added unit tests. * updated headers. * fixes. * cleanup. * Adding support for labels in prometheus and expvar. * Refactor code * fix readme * Fix copyright year --------- Co-authored-by: Mirza Sohail Hussain <[email protected]> Co-authored-by: Pulak Bhowmick <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mat001Mat001Mat001 approved these changes

@msohailhussainmsohailhussainAwaiting requested review from msohailhussain

@jaeoptjaeoptAwaiting requested review from jaeopt

+1 more reviewer

@prisma-cloud-devsecopsprisma-cloud-devsecops[bot]prisma-cloud-devsecops[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yasirfolio3@Mat001@pulak-opti@msohailhussain