Skip to content

[FSSDK-11175] Update: Implement Decision Service methods to handle CMAB#457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FarhanAnjum-opti merged 29 commits into from
Jul 7, 2025
Merged

[FSSDK-11175] Update: Implement Decision Service methods to handle CMAB #457

FarhanAnjum-opti merged 29 commits into from
Jul 7, 2025

Conversation

@FarhanAnjum-opti
Copy link
Contributor

@FarhanAnjum-optiFarhanAnjum-opti commented Jun 16, 2025

Summary

Decision Service methods to handle CMAB

Test plan

Added unit tests

Issues

FSSDK-11175

@Mat001Mat001 requested review from Mat001 and raju-optiJune 16, 2025 18:43
Mat001
Mat001 requested changes Jun 16, 2025
View reviewed changes
@FarhanAnjum-opti
update: fix logger reference in DefaultCmabClient initialization and …
fe100cb
…add __init__.py for cmab module
@FarhanAnjum-opti
update: enhance error logging for CMAB fetch failures with detailed m…
60a4ada
…essages and add a test for handling 500 errors
@FarhanAnjum-opti
update: enhance decision result handling by introducing VariationResu…
265d82b
…lt and updating get_variation return type to include detailed error information
@FarhanAnjum-opti
update: refactor get_variation return structure and change tests acco…
6ca1102
…rdingly
@FarhanAnjum-opti
-Error propagated to optimizely.py
c2b3d96
-test cases changed to handle return type dicts of DecisionResult and VariationResult
Mat001
Mat001 approved these changes Jun 23, 2025
View reviewed changes
Copy link
Contributor

@Mat001Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Have Raju review too.

raju-opti
raju-opti requested changes Jul 2, 2025
View reviewed changes
raju-opti
raju-opti approved these changes Jul 7, 2025
View reviewed changes
Copy link

@raju-optiraju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with few small comments

@FarhanAnjum-optiFarhanAnjum-opti merged commit 81f5be9 into masterJul 7, 2025
23 checks passed
@FarhanAnjum-optiFarhanAnjum-opti deleted the farhan-anjum/FSSDK-11175-add-decision-service-methods-for-cmab branch July 7, 2025 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mat001Mat001Mat001 approved these changes

@raju-optiraju-optiraju-opti approved these changes

Assignees

@FarhanAnjum-optiFarhanAnjum-opti

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FarhanAnjum-opti@Mat001@raju-opti