Improved pull request "Files Changed" experience feedback #163932
Replies: 2365 comments 861 replies
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
BetaWas this translation helpful?Give feedback.
-
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
BetaWas this translation helpful?Give feedback.
-
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
BetaWas this translation helpful?Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
BetaWas this translation helpful?Give feedback.
-
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
BetaWas this translation helpful?Give feedback.
-
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
BetaWas this translation helpful?Give feedback.
-
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
BetaWas this translation helpful?Give feedback.
-
BetaWas this translation helpful?Give feedback.
-
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
BetaWas this translation helpful?Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
The tab for |
BetaWas this translation helpful?Give feedback.
-
Not sure if this is the sort of feedback you're after, but the |
BetaWas this translation helpful?Give feedback.
-
|
BetaWas this translation helpful?Give feedback.
-
On the Files changed tab I can only see 19 files out of 66. Why? |
BetaWas this translation helpful?Give feedback.
-
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
BetaWas this translation helpful?Give feedback.
-
It doesn't always seem to remember if hide whitespace was turned on. |
BetaWas this translation helpful?Give feedback.
-
I really miss the ability to go to the next not reviewed file. Also it would be great to see which files are reviewed or not in the file tree. |
BetaWas this translation helpful?Give feedback.
-
In the single file mode
Overall, I don't like the single view at all. I use browser-based text search a lot to navigate around diffs and both the single-file flow as well as react in general make this impossible now. Huge regression as far as I'm concerned. /unsubscribe |
BetaWas this translation helpful?Give feedback.
-
BetaWas this translation helpful?Give feedback.
-
I find collapsed-by-default comments really frustrating. Often, the main reason I'm looking at the diff is to see comments in context. It took me a long time to discover the little disclosure buttons on the right side of the diff. There's usually no reason for me to look at the right edge of the diff (on a wide screen and with standard line length limits, it's very far away from the main content), so even now that I know they're there, I find it very hard to scan the PR and find the small user icons where the comments are. I haven't found a way to auto-expand all comments, and the "Comments" sidebar has many issues described already here (in particular, the "Jump to comment in diff" button frequently does nothing, including when the comments are collapsed, so it does nothing to help me find the comments' context). |
BetaWas this translation helpful?Give feedback.
-
clicking on the PR title to scroll to top isn't working for me in the |
BetaWas this translation helpful?Give feedback.
-
Having a cap on comments displayed has become an issue in my teams pipeline due to its requirement to have some note on each file as a sanity check or explanation. Can we can a configurable limit so we understand that yes there will be a performance hit but in the old method we could still see all the comments no matter the number. |
BetaWas this translation helpful?Give feedback.
-
I'm trying to review https://github.com/rancher-sandbox/rancher-desktop/pull/9632/changes?show-vendored-files=false#r2611078398 ![]() I don't think the animated greeking will resolve. I can load https://github.com/rancher-sandbox/rancher-desktop/pull/9632/changes?show-vendored-files=false&show-viewed-files=false#diff-ccd3e520cb49f587708090deb8eb478fecf08fe874a6ad8d07d307d83e1efbbd (or an equivalent, see complaint about greeking) I can scroll to and hover over this: When I click, the right sidebar goes away, leaving me with: Neither clicking on the heads nor clicking the jump to comment thing work: But, what does happen is that when I click comments again, I'm scrolled back to the TOP of the comments list. |
BetaWas this translation helpful?Give feedback.
-
When viewing a single commit in the "Files changed" tab, in "files," you could use the p/n key to shortcut prev/next. This isn't possible in "changes." |
BetaWas this translation helpful?Give feedback.
-
|
BetaWas this translation helpful?Give feedback.
-
When reviewing commit by commit, it's quite slow, because one has to:
I'd love two buttons, "next commit" and "prev commit", or a revert to the previous menu (with multiselect enabled) |
BetaWas this translation helpful?Give feedback.
-
I love the file by file view on PRs with large number of files, makes it much quicker to load and easier to review. |
BetaWas this translation helpful?Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
The projects I maintain use a rebase workflow where commits are preserved and we care a lot about the quality of those commits. So, we review one commit at a time. It'd be useful if the "prev/next" buttons were available at the bottom of the page as well as the top (either a second set, or putting them in the sticky header). I do really like that the "Submit review" box now lists the pending comments! That's very helpful. EDIT: Kind of a bug report: If there's only one commit in a PR, it seems to be impossible to view the changes with the commit message visible. |
BetaWas this translation helpful?Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Landed here from y-day's update https://github.blog/changelog/2025-12-11-review-commit-by-commit-improved-filtering-and-more-in-the-pull-request-files-changed-public-preview/ Should've joined months ago, my bad. Well, at least this screen is on y'alls active radar. Bits and pieces are coming along, but comment management (esp. with CI bots participation) is by far the biggest UX problem for our review team. Even as of today, comment overlay on a simple 2-file PR
Hopefully someone's listening 🙏 |
BetaWas this translation helpful?Give feedback.
-
I really do not like the single file view. Hopefully this will be a toggle in future |
BetaWas this translation helpful?Give feedback.
-
Doesn't work for large PRs (large diffs per file, many files changed). |
BetaWas this translation helpful?Give feedback.
























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Important
We’re actively investing in performance improvements for the new File Changed page, and as part of that work, the single file mode will be removed as the default view for large PRs (will still be optional) in the next couple of weeks. We know it hasn’t been the smoothest experience, and we appreciate your patience. It was only a temporary workaround for large PRs while we built a more scalable, long-term solution, which is now work in progress.
Important
You can opt in to the public preview from any pull request via
✨Try the new experiencein the upper-right corner. You can return to the classic view by clicking the “switch back” link.About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
What’s new ?
Performance 🚀
UX ✨
Accessibility
What's missing? 🟨
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
BetaWas this translation helpful?Give feedback.
All reactions