Add ReaderT#ask#119
Merged
Add ReaderT#ask #119
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
7h3kk1d commented Feb 21, 2022
Comment on lines +216 to +217
| //noinspection Convert2MethodRef | ||
| return readerT(a -> pureM.apply(a)); |
MemberAuthor
There was a problem hiding this comment.
Also I'm not sure why this was necessary to make it compile under java 1.8.
Collaborator
There was a problem hiding this comment.
Yeah, pretty unfortunate. You can ascribe the type of the apply or the ReaderT, but either way you have to suppress a warning so dealer's choice.
CorwinTanner approved these changes Feb 26, 2022
Comment on lines +216 to +217
| //noinspection Convert2MethodRef | ||
| return readerT(a -> pureM.apply(a)); |
Collaborator
There was a problem hiding this comment.
Yeah, pretty unfortunate. You can ascribe the type of the apply or the ReaderT, but either way you have to suppress a warning so dealer's choice.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still not sure this is the right thing to add since it's so easy to pass
pure#applyat the call site. It might be better to have an interface method onMonadReaderso you don't need to pass the pure.