FoldRight fixes for Monoid/Semigroup#128
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #127
Sidenote
Monoid::foldMapseems to be where short-circuiting is currently implemented. Something that was going to be addressed in the incomplete https://github.com/palatable/lambda/pull/122/files. For obvious reasons, it doesn't seem to address semigroups that should short-circuit. In addition, it has some odd behavior forMonoid::foldRight. For example the function application will now matchSemigroup::foldRight, butand().foldRight(true, repeat(false)).value()does not short circuit with the current implementation ofMonoid::foldRight. I'm tempted to removefoldLeft/foldRightfromMonoidand add alazilyApplytoSemigroupthat would allow for users to override for short-circuiting behavior.