Skip to content

Conversation

@ramvikrams
Copy link
Contributor

@ramvikramsramvikrams commented Apr 17, 2023

@ramvikramsramvikrams changed the title GH - 624: Added dtype arg to reaf_sqlGH - 624: Added dtype arg to read_sqlApr 17, 2023
@twoertweintwoertwein requested a review from Dr-IrvApril 19, 2023 17:44
@twoertweintwoertwein mentioned this pull request Apr 20, 2023
2 tasks
Copy link
Collaborator

@Dr-IrvDr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do 2 things here:

  1. Another change to read_sql() is the introduction of the dtype_backend argument, so can you make that change in this PR?
  2. Can you modify your test to use a different argument for dtype, e.g., something likedtype={"int_column": float} should work. You may need to experiment with that.

@ramvikrams
Copy link
ContributorAuthor

Can you do 2 things here:

  1. Another change to read_sql() is the introduction of the dtype_backend argument, so can you make that change in this PR?
  2. Can you modify your test to use a different argument for dtype, e.g., something likedtype={"int_column": float} should work. You may need to experiment with that.

Done

Copy link
Collaborator

@Dr-IrvDr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-IrvDr-Irv merged commit b9895fd into pandas-dev:mainApr 21, 2023
@ramvikramsramvikrams deleted the t200 branch April 21, 2023 14:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ramvikrams@twoertwein@Dr-Irv