Skip to content

GH: 624 - Added dtype_backend to all read_* functions#655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dr-Irv merged 14 commits into from
Apr 24, 2023
Merged

GH: 624 - Added dtype_backend to all read_* functions #655

Dr-Irv merged 14 commits into from
Apr 24, 2023

Conversation

@ramvikrams
Copy link
Contributor

@ramvikramsramvikrams commented Apr 21, 2023•
edited
Loading

@ramvikramsramvikrams changed the title GH: 624 - Added dtype_backend to all functionsGH: 624 - Added dtype_backend to all read_* functionsApr 21, 2023
Dr-Irv
Dr-Irv requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Dr-IrvDr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some re-ordering to do

Dr-Irv
Dr-Irv requested changes Apr 21, 2023
View reviewed changes
Copy link
Collaborator

@Dr-IrvDr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a couple other things

@ramvikramsramvikrams requested a review from Dr-IrvApril 22, 2023 14:49
Dr-Irv
Dr-Irv reviewed Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@Dr-IrvDr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Had one question on a test.

Dr-Irv
Dr-Irv approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@Dr-IrvDr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ramvikrams

@Dr-IrvDr-Irv merged commit c67da63 into pandas-dev:mainApr 24, 2023
@ramvikramsramvikrams deleted the t220 branch April 24, 2023 17:56
@Dr-IrvDr-Irv mentioned this pull request Apr 24, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dr-IrvDr-IrvDr-Irv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Version 2.0 Compatibility Tracker

2 participants

@ramvikrams@Dr-Irv