Skip to content

Conversation

@askmyhat
Copy link
Contributor

No description provided.

Copy link
Member

@twoertweintwoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case, something like:

check(assert_type(df.info(show_counts=True), None), None) check(assert_type(df.info(show_counts=None), None), None)

@askmyhataskmyhat changed the title Replaced null_counts with show_counts in df.info()Added types to df.info()Feb 22, 2024
Copy link
Collaborator

@Dr-IrvDr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes

@askmyhataskmyhat requested a review from Dr-IrvFebruary 23, 2024 17:18
Copy link
Collaborator

@Dr-IrvDr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @askmyhat

@Dr-IrvDr-Irv merged commit 02abbdb into pandas-dev:mainFeb 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@askmyhat@twoertwein@Dr-Irv