Skip to content

TYP: Ignore xlsxwriter _book typing#62348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mroeschke merged 1 commit into from
Sep 15, 2025
Merged

TYP: Ignore xlsxwriter _book typing #62348

mroeschke merged 1 commit into from
Sep 15, 2025

Conversation

@mroeschke
Copy link
Member

@mroeschkemroeschke commented Sep 15, 2025

e.g. https://github.com/pandas-dev/pandas/actions/runs/17741519922/job/50416374964

A way to better type _book can be done in a follow up.

@mroeschkemroeschke added this to the 3.0 milestone Sep 15, 2025
@mroeschkemroeschke added the Typing type annotations, mypy/pyright type checking label Sep 15, 2025
@Alvaro-Kothe
Copy link
Member

Alvaro-Kothe commented Sep 15, 2025•
edited
Loading

I've raised an issue on xlsxwriterjmcnamara/XlsxWriter#1152 and a patch is available on version 3.2.7 that would fix this issue, which is available on pypi, but not on conda-forge.

@mroeschke
Copy link
MemberAuthor

mroeschke commented Sep 15, 2025

Going to merge this to get the CI to green, but we can undo this once the new version of xlswriter is on conda forge. Thanks for investigating @Alvaro-Kothe

@mroeschkemroeschke merged commit e503c13 into pandas-dev:mainSep 15, 2025
45 checks passed
@mroeschkemroeschke deleted the fix/typing branch September 15, 2025 20:33
@simonjayhawkins
Copy link
Member

simonjayhawkins commented Sep 15, 2025

Thanks @mroeschke

@rhshadrachrhshadrach added the IO Excel read_excel, to_excel label Sep 15, 2025
@jorisvandenbosschejorisvandenbossche modified the milestones: 3.0, 2.3.3Sep 20, 2025
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Sep 20, 2025

@meeseeksdev backport to 2.3.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 20, 2025
@mroeschke@meeseeksmachine
Backport PRpandas-dev#62348: TYP: Ignore xlsxwriter _book typing
0973b32
@meeseeksmachinemeeseeksmachine mentioned this pull request Sep 20, 2025
Merged
jorisvandenbossche pushed a commit that referenced this pull request Sep 21, 2025
@meeseeksmachine@mroeschke
Backport PR#62348on branch 2.3.x (TYP: Ignore xlsxwriter _book typi…
a25f560
…ng) (#62391) Co-authored-by: Matthew Roeschke <[email protected]>
eicchen pushed a commit to eicchen/pandas that referenced this pull request Oct 18, 2025
@mroeschke@eicchen
TYP: Ignore xlsxwriter _book typing (pandas-dev#62348)
773a19c
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhshadrachrhshadrachAwaiting requested review from rhshadrachrhshadrach is a code owner

Assignees

No one assigned

Labels

IO Excelread_excel, to_excelTypingtype annotations, mypy/pyright type checking

Projects

None yet

Milestone

2.3.3

Development

Successfully merging this pull request may close these issues.

5 participants

@mroeschke@Alvaro-Kothe@simonjayhawkins@jorisvandenbossche@rhshadrach