Skip to content

Backport to 2.3.x: REGR: from_records not initializing subclasses properly (#60726)#62436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mroeschke merged 1 commit into from
Sep 24, 2025
Merged

Backport to 2.3.x: REGR: from_records not initializing subclasses properly (#60726) #62436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/source/whatsnew/v2.3.3.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,12 @@ Bug fixes
- The :meth:`DataFrame.iloc` now works correctly with ``copy_on_write`` option when assigning values after subsetting the columns of a homogeneous DataFrame (:issue:`60309`)


Other Bug fixes
~~~~~~~~~~~~~~~~

- Fixed regression in :meth:`DataFrame.from_records` not initializing subclasses properly (:issue:`57008`)


.. ---------------------------------------------------------------------------
.. _whatsnew_233.contributors:

Expand Down
6 changes: 4 additions & 2 deletions pandas/core/frame.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -2549,8 +2549,10 @@ def maybe_reorder(

manager=_get_option("mode.data_manager", silent=True)
mgr=arrays_to_mgr(arrays, columns, result_index, typ=manager)

returncls._from_mgr(mgr, axes=mgr.axes)
df=DataFrame._from_mgr(mgr, axes=mgr.axes)
ifclsisnotDataFrame:
returncls(df, copy=False)
returndf

defto_records(
self, index: bool=True, column_dtypes=None, index_dtypes=None
Expand Down
7 changes: 7 additions & 0 deletions pandas/tests/frame/test_subclass.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -784,6 +784,13 @@ def test_constructor_with_metadata():
assertisinstance(subset, MySubclassWithMetadata)


deftest_constructor_with_metadata_from_records():
# GH#57008
df=MySubclassWithMetadata.from_records([{"a": 1, "b": 2}])
assertdf.my_metadataisNone
asserttype(df) isMySubclassWithMetadata


classSimpleDataFrameSubClass(DataFrame):
"""A subclass of DataFrame that does not define a constructor."""

Expand Down
Loading