Refactor test_combine_first dataframe#63295
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Tsmith-77 commented Dec 8, 2025
| combined=tail.combine_first(head) | ||
| assert (combined["A"][:10] ==0).all() | ||
| # no overlap |
ContributorAuthor
There was a problem hiding this comment.
The no overlap case had the same setup as the disjoint case, just with assertions that had a different focus, so I moved those assertions up into test_combine_first_disjoint and then removed the reverse overlap code.
| @pytest.fixture | ||
| defreordered_frame(float_frame): |
Member
There was a problem hiding this comment.
Could you just inline this logic in the only 2 tests where this is used?
mroeschke approved these changes Dec 10, 2025
mroeschke merged commit 66e22c5 into pandas-dev:main 41 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Member
mroeschke commented Dec 10, 2025
Thanks @Tsmith-77 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.