STY: Use strict arg in zip() in pandas/tests/plotting#63296
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I added strict=True parameter to 30 zip() calls across 8 files in the pandas/tests/plotting directory to enforce Ruff rule B905. This ensures that all zipped iterables have equal lengths, making the tests more robust and catching potential bugs early during testing. Files modified: - common.py: 5 zip() calls - frame/test_frame_color.py: 11 zip() calls - frame/test_frame_groupby.py: 2 zip() calls - test_boxplot_method.py: 3 zip() calls - test_datetimelike.py: 5 zip() calls - test_groupby.py: 1 zip() call - test_hist_method.py: 2 zip() calls - test_series.py: 1 zip() call
The comment explicitly states that 'unique and colors length can be differed depending on slice value', so strict=True should not be used in this zip() call as it would raise ValueError when lengths don't match. Fixes test failures in plotting tests.
Fixed test_line_colors_and_styles_subplots and test_kde_colors_and_styles_subplots by removing strict=True. These tests expect default_colors to be longer than axes.
mroeschke approved these changes Dec 8, 2025
mroeschke merged commit 6fcb267 into pandas-dev:main 45 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Member
mroeschke commented Dec 8, 2025
Thanks @AKHIL-149 |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the
strict=Trueparameter to 30zip()calls across 8 files in thepandas/tests/plottingdirectory to enforce Ruff rule B905.Changes made:
common.py: 5 zip() callsframe/test_frame_color.py: 11 zip() callsframe/test_frame_groupby.py: 2 zip() callstest_boxplot_method.py: 3 zip() callstest_datetimelike.py: 5 zip() callstest_groupby.py: 1 zip() calltest_hist_method.py: 2 zip() callstest_series.py: 1 zip() callThis ensures that all zipped iterables have equal lengths, making the tests more robust and catching potential bugs early during testing.
Checklist:
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature - N/A: Style fix doesn't require whatsnew entryAGENTS.md- N/A: Manual code changes