.gitignore changes: Thumbs.db and public directory (with all subdirectories and files).#283
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously had many files/subdirectories broken out in the `.gitignore`; seems the idea is just to ignore the entire directory, which can be done with just the one line. Does not address any open issue; just addresses potential confusion over what should/shouldn't be ignored in `public`.
Not specifying any directory means it'll catch all `Thumbs.db` files in any directory.
Contributor
geoffp commented Mar 10, 2016
Thanks for this, @zacanger. @bmuenzenmeyer, I gave this a quick test, and it seems to work. Any objections? |
Member
bmuenzenmeyer commented Mar 10, 2016
No objections, as long as a base install works. I love the notion of cleaning stuff up like this. This ignore file is another place that showcases how ~4 years of hacking on the repo have evolved. |
Contributor
geoffp commented Mar 10, 2016
Groovy |
geoffp added a commit that referenced this pull request Mar 10, 2016
`.gitignore` changes: `Thumbs.db` and `public` directory (with all subdirectories and files).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #
Does not address any open issue; just addresses potential confusion over what should/shouldn't be ignored in
public, and catches allThumbs.dbfiles.Summary of changes:
Previously had many files/subdirectories broken out in the
.gitignore; seems the idea is just to ignore the entire directory, which can be done with just the one line.Not specifying subdirectory for
Thumbs.dbfiles will let the gitignore just catch all of 'em.