Skip to content

Conversation

@prateekiiest
Copy link
Contributor

Addresses #689 - Issue

Summary of changes:

  • current branching strategy
  • commits should reference issues
  • large enhancements should start with an issue, not a cold PR

@prateekiiest
Copy link
ContributorAuthor

@bmuenzenmeyer reviews pls

Copy link
Member

@bmuenzenmeyerbmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution - I might wordsmith a bit and prep this and be aware that #696 is coming too.

Thanks again!

@bmuenzenmeyerbmuenzenmeyer added the hacktoberfest 🌾 https://hacktoberfest.digitalocean.com label Oct 1, 2017
@bmuenzenmeyerbmuenzenmeyer merged commit c707eee into pattern-lab:devOct 1, 2017
@prateekiiestprateekiiest deleted the patch-1 branch October 3, 2017 05:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest 🌾https://hacktoberfest.digitalocean.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@prateekiiest@bmuenzenmeyer