Refactor the root Pattern Lab build into a proper class#742
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…f an end-to-end async build process
…patternlab state object
…te, since they're still very much invoked from outside. Maybe that's okay.
Member
bmuenzenmeyer commented Oct 24, 2017
pardon the commit to this - all the 💯 goes to @geoffp on this! |
Member
bradfrost commented Oct 27, 2017
I'm way out of my depths here, but it looks like fascinating and nitty-gritty work. Thanks @geoffp! |
ContributorAuthor
geoffp commented Oct 27, 2017
Thanks fellas! It is pretty abstract work, but damn if I don’t enjoy a good refactoring. |
Member
bradfrost commented Oct 27, 2017
@geoffp ha! You sound like me refactoring the frontend code. I'm one of those weirdos that likes spring cleaning and organization and stuff. ¯_(ツ)_/¯ |
ContributorAuthor
geoffp commented Oct 27, 2017
@bradfrost hey, I know the feeling. It’s nice to take up something kinda messy and leave behind something beautiful, whether it’s visual or in code. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #572
Summary of changes:
I've begun the process of refactoring the loosely organized build step into a real class with a real constructor. The goal here is to make to whole process more comprehensible ahead of the async work, which would be difficult to reason about and debug without it.
I plan to continue this work in small, careful steps.
If you merge, please leave the branch and I'll just keep jamming on it as time allows. Async rendering or bust.