- Notifications
You must be signed in to change notification settings - Fork 106
feat(label-group): create pf-label-group element#2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base:main
Are you sure you want to change the base?
feat(label-group): create pf-label-group element #2949
Uh oh!
There was an error while loading. Please reload this page.
Conversation
saraDahanCode commented Oct 27, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
changeset-botbot commented Oct 27, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
🦋 Changeset detectedLatest commit: cffdff2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…verflow, and basic label groups
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
saraDahanCode commented Nov 3, 2025
@bennypowers When running the dev server, three TypeScript type errors occur in tools/pfe-tools/dev-server/config.ts: cors, cacheBusterMiddleware, liveReloadTsChangesMiddleware middlewares fail due to incompatible Koa types. The errors indicate Property 'back' is missing and type conflicts between different @types/koa versions. This prevents the dev server from starting and causes the tests to fail. Example snippet: 127 cors, // TS2322: Type '(ctx: Context, next: Next) => Promise' is not assignable to type 'Middleware' It seems related to multiple @types/koa versions being used in the project. |
mguetta1 commented Nov 4, 2025
@markcaron@bennypowers@zeroedin Hi, |
420bb96 to bc5f6c9CompareUh oh!
There was an error while loading. Please reload this page.
elements/pf-label-group/demo/label-group-with-a-very-long-name.html Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
feat(label-group): change demo
| /** | ||
| * Accessible label for the label group when no category name is provided. | ||
| * @default '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * @default '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for all the others. we don't need @default, our analyzer will pick it up from the initializer
| if(filledYes)filledYes.checked=true; | ||
| } | ||
| functionopenModal(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not clear what this function is doing.
add a trigger button for the modal, and use modal events to handle close, as in line 128
| console.log('modal is created'); | ||
| modal.innerHTML=` | ||
| <h2 slot="header">Add label</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modal content is static, so put it in the HTML rather than in javascript, and call showModal() on it when you need to
Partially addresses #2935
What I did
<pf-label-group>element.<pf-label>elements with support for removable and overflow states.overflowbehavior that collapses extra labels into a "+N more" indicator.LabelGroupCloseEventwhen the whole group is closed./demo/pf-label-group/showing various configurations (horizontal, vertical, removable, overflow, and closable examples)..changesetfile with typeminorto trigger a release.Testing Instructions
npm startand openhttp://localhost:8000/elements/pf-label-group/demo/.LabelCloseEventis fired.npm run lintandnpm testto ensure all checks pass successfully.Notes to Reviewers
.changesetfile is set to minor, since this PR introduces a new element.