non-static QueueSubscriberInterface::getSubscribedQueues()#1249
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I propose to make this accessor non-static to allow developers build more sophisticated mechanism of subscription. For example I have code: ```php abstract class AbstractConsumer implements Processor, QueueSubscriberInterface{// .... // .... public function process(Message $message, Context $context){$event = $this->serializer->deserialize($message->getBody(), $this->eventModel(), $this->format()); try{$this->doProcessEvent($event)} catch (OperationNotSupportedException $e){return self::REJECT} catch (OperationFailedException $e){return self::REQUEUE} return self::ACK} abstract protected function eventModel(): string; abstract protected function doProcessEvent(EventInterface $event): void; // FYI getSubscribedQueues() is implemented by child classes } ``` where `getSubscribedQueues()` is implemented by child classes. In my project I want to introduce `EventProcessorInterface`, which can process events data mapped to `eventModel()` considering `getSubscribedEvents(): string[]`. But I cannot INJECT `EventProcessorInterface` to `AbstractConsumer` and delegate `QueueSubscriberInterface::getSubscribedQueues()` to `EventProcessorInterface::getSubscribedEvents()` because it is static method!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to make this accessor non-static to allow developers build more flexible mechanism of subscription. For example I have code:
where
getSubscribedQueues()is implemented by child classes.In my project I want to introduce
EventProcessorInterface, which can process events data mapped toeventModel()consideringgetSubscribedEvents(): string[]. But I cannot INJECTEventProcessorInterfacetoAbstractConsumerand delegateQueueSubscriberInterface::getSubscribedQueues()toEventProcessorInterface::getSubscribedEvents()because it is static method!