Make parenthesized expressions advance the limit count on preg_split

[tml]

Perhaps the existing behaviour is preferred; if so, the documentation should make this more clear. As I view it, I think counting the parenthesized expressions feels like the right thing to do.

[Enelar]

@tml thanks a lot!
Explaining example: http://sandbox.onlinephpfunctions.com/code/3015d9deff98da365cce803d0486a1039101117f

[staabm]

you should add a unit test which reproduces the issue this change is fixing

[tml]

Sure; but the fix was so painfully obvious, I figured it'd be good to get it out there and see if anyone argues that the existing behaviour is preferable/intentional while I brush up on how to write a pht - it's been a while. :) On Oct 18, 2017 12:48 AM, "Markus Staab" <notifications@github.com> wrote: you should add a unit test which reproduces the issue this change is fixing — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2860 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACJTCCVPhLLiRSMpqIa5KnQUrqRid7Vks5stZ88gaJpZM4P9Mx2> .

[tml]

@krakjoe I don't know how to make the Appveyor builds run, any help there?

[krakjoe]

@tml av is almost a total mystery to me ...

@weltling what's this about a missing key ?

[weltling]

@krakjoe it seems some AppVeyor issue with the cache. I've posted to the existing ticket a day ago http://help.appveyor.com/discussions/problems/8572-cache-is-broken . I'll do some experiments yet, that might fix it. Will check with them further, anyway.

Thanks.

[tml]

Thanks. Can we remove the waiting on author tag?

[weltling]

@tml I've disabled the AppVeyor cache, that's the solution for now. If you pull new from the dev branch, it'll fetch the new .appveyor.yml.

Thanks.

[nikic]

The logic here does not look right to me. E.g. if you only have NO_EMPTY but not DELIM_CAPTURE, this is still going to count empty matches, even though they won't be returned, right?

[krakjoe]

This appears to have been rejected.

[tml]

No, it was merged in commit c19d519. :)