Skip to content

Conversation

@emilykl
Copy link
Contributor

@emilyklemilykl commented Jan 19, 2026

  • The baseline images for some of the MapLibre image tests have changed due to the map tiles for the 'carto' map styles (hosted on basemaps.cartocdn.com) being visually modified by Carto. This has caused the CI image tests to fail. This PR updates the baseline images so that the CI is green again.

  • Separately: Chrome version 144 seems to be causing a large number of the WebGL Jasmine tests to fail (see failures here). This shows up in the webgl-jasmine-chromeLatest job. This PR pins the version of Chrome used by webgl-jasmine-chromeLatest to 143. This pin should be temporary and removed as soon as Chrome patches fix the issues; I've opened [maintenance] Remove Chrome version 143 pin in webgl-jasmine-chromeLatest #7693 to track.

@emilyklemilyklforce-pushed the update-map-baselines-jan-2026 branch 3 times, most recently from a1746d6 to 52a3fafCompareJanuary 20, 2026 05:42
…issues with 144) and bump pinned versions to 143 elsewhere
@emilyklemilyklforce-pushed the update-map-baselines-jan-2026 branch from 52a3faf to b7d4a50CompareJanuary 20, 2026 16:21
@emilyklemilykl changed the title chore: update map baselines due to basemap changechore: update map baselines due to basemap change, upgrade Chrome versions in CI, and add temporary pin for flaky Chrome versionJan 20, 2026
@camdecoster
Copy link
Contributor

@emilykl I keep seeing the no-gl-jasmine test suite failing. Do you know why that would be?

@emilykl
Copy link
ContributorAuthor

@camdecoster I bumped the Chrome version everywhere, so presumably that's why. Going to try a diff Chrome version. It's a little odd though.

@emilyklemilyklforce-pushed the update-map-baselines-jan-2026 branch from 7980db1 to 95340c8CompareJanuary 21, 2026 19:15
@emilykl
Copy link
ContributorAuthor

Well that was a trip. @camdecoster I don't know WHY the CI fails when I update the Chrome version for the other CI jobs, but I put it back to the way it was initially, and everything is passing now.

@emilyklemilykl changed the title chore: update map baselines due to basemap change, upgrade Chrome versions in CI, and add temporary pin for flaky Chrome versionchore: update map baselines due to basemap change, and add temporary pin for flaky Chrome versionJan 21, 2026
@emilyklemilykl merged commit a6a10f9 into masterJan 21, 2026
6 checks passed
@emilyklemilykl deleted the update-map-baselines-jan-2026 branch January 21, 2026 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@emilykl@camdecoster