Skip to content

Conversation

@babaissarkar
Copy link
Contributor

@babaissarkarbabaissarkar commented Mar 23, 2025

Resolves#994

Minerals

Screenshot from 2025-03-23 23-00-15Screenshot from 2025-03-23 23-00-09Screenshot from 2025-03-23 23-00-04Screenshot from 2025-03-23 22-59-58Screenshot from 2025-03-23 22-59-53Screenshot from 2025-03-23 22-59-48Screenshot from 2025-03-23 22-59-44Screenshot from 2025-03-23 22-59-39Screenshot from 2025-03-23 22-59-34Screenshot from 2025-03-23 22-59-29Screenshot from 2025-03-23 22-59-24Screenshot from 2025-03-23 22-59-18Screenshot from 2025-03-23 22-59-13Screenshot from 2025-03-23 22-59-07Screenshot from 2025-03-23 22-59-03Screenshot from 2025-03-23 22-58-58

Alloys

Screenshot from 2025-03-24 22-02-45Screenshot from 2025-03-24 22-02-37Screenshot from 2025-03-24 22-02-30Screenshot from 2025-03-24 22-02-21Screenshot from 2025-03-24 22-02-16Screenshot from 2025-03-24 22-02-07Screenshot from 2025-03-24 22-02-00Screenshot from 2025-03-24 22-01-52Screenshot from 2025-03-24 22-01-45Screenshot from 2025-03-24 22-01-39Screenshot from 2025-03-24 22-01-31Screenshot from 2025-03-24 22-01-24Screenshot from 2025-03-24 22-01-17Screenshot from 2025-03-24 22-01-09Screenshot from 2025-03-24 22-01-00Screenshot from 2025-03-24 22-00-53

@babaissarkarbabaissarkarforce-pushed the theme-line-numbers-contrast-fix branch from c5bece1 to 1707cdeCompareMarch 24, 2025 16:33
@babaissarkarbabaissarkarforce-pushed the theme-line-numbers-contrast-fix branch from 1707cde to 165dab6CompareMarch 24, 2025 16:37
@babaissarkarbabaissarkar marked this pull request as ready for review March 24, 2025 16:37
@babaissarkarbabaissarkar changed the title increase contrast of line numbers (Minerals)increase contrast of line numbersMar 24, 2025
@SteftervStefterv added this to the 4.4.2 milestone Mar 24, 2025
@SteftervStefterv requested a review from SableRafMarch 24, 2025 16:42
@SableRaf
Copy link
Collaborator

I've tested on Windows 10 and macOS 13.4 and it looks good to me!

The only issue I can see with this approach is that—with the larger numbers—line numbers over 9999 overflow on the left.

Image

The current version can fit more numbers in the gutter.

Image

That said, I doubt this will affect most users and this should not be a blocker for this PR. Just something to keep in mind for later (cc @Stefterv).

@Stefterv
Copy link
Collaborator

@SableRaf That's some high-level QA right there ❤️

@babaissarkar Thank you!

@SteftervStefterv merged commit 6ccf5b9 into processing:mainMar 24, 2025
12 checks passed
@SableRaf
Copy link
Collaborator

@all-contributors please add @babaissarkar for Code and Accessibility

@allcontributors
Copy link
Contributor

@SableRaf

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 39663

@SableRaf
Copy link
Collaborator

@all-contributors please add @babaissarkar for Code and Accessibility

@allcontributors
Copy link
Contributor

@SableRaf

I've put up a pull request to add @babaissarkar! 🎉

@SableRaf
Copy link
Collaborator

SableRaf commented Mar 29, 2025

Hi @babaissarkar and @Stefterv 👋

I just noticed that at smaller font sizes the line numbers start colliding. Note: This was already the case in 4.3.4 but it was less pronounced.

image

I don't know whether we need to support font sizes that small. Maybe it's reasonable to limit how small the font can get in the editor? Otherwise we'd need a way to adjust the size of the line numbers for smaller font sizes in the editor.

image

@babaissarkarbabaissarkar deleted the theme-line-numbers-contrast-fix branch March 30, 2025 17:21
@babaissarkar
Copy link
ContributorAuthor

The font size for line numbers could be adaptive: it changes in proportion to the editor font, though the parent issue may crop up again.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Line numbers need more contrast

3 participants

@babaissarkar@SableRaf@Stefterv