Skip to content

Conversation

@catilac
Copy link
Collaborator

@catilaccatilac commented Aug 13, 2025

Limits the Welcome to Beta screen to once per downloaded revision.

Closes#1198

@catilaccatilac requested a review from SteftervAugust 13, 2025 19:30
Comment on lines 145 to 148
System.err.println("MOON DEBUG" +
Base.getRevision() + ", and lastBetaSeen is " +
lastBetaSeen + ".");

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove this, i suppose

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, feel free to use Messages.log that will be hidden for users and will give us valuable information when looking at the logs

JFrame(windowTitle).apply{
val close ={dispose() }
val close ={
Preferences.set("beta.last_beta_welcome_seen", getRevision().toString())
Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need a better key name. wondering your thoughts. should it be update.beta_welcome or something?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update.beta_prompt

if(latest < Base.getRevision()){
WelcomeToBeta.showWelcomeToBeta();

StringlastBetaSeenStr = Preferences.get("beta.last_beta_welcome_seen");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say using Preferences.getInteger() would be a better choice here, to make sure it is never empty you can add the key to the defaults.txt in build/shared/lib/defaults.txt

@SteftervStefterv added this to the 4.4.6 milestone Aug 14, 2025
@SteftervStefterv changed the title WIP: Display once per revision numberDisplay Welcome to Beta once per revisionAug 14, 2025
@SteftervStefterv marked this pull request as ready for review August 14, 2025 05:12
@SableRafSableRaf merged commit 1ba7269 into processing:mainAug 14, 2025
6 checks passed
@SableRaf
Copy link
Collaborator

@all-contributors please add @catilac for code

@allcontributors
Copy link
Contributor

@SableRaf

I've put up a pull request to add @catilac! 🎉

@catilaccatilac deleted the beta-welcome-logic branch August 14, 2025 14:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable beta welcome message

3 participants

@catilac@SableRaf@Stefterv