Skip to content

Conversation

@lassevonpfeil
Copy link
Contributor

Added two links to the help menu bar. Opens either processing forum or GitHub issues tab in standard browser when clicked. Resolves Issue #1208
Implemented the new features in JavaEditor.java and also provided German language support.
Used Desktop.getDesktop() and then Desktop.browse(oURL) to follow the link.
I Placed the MenuItems between "Download official reference" and "library reference".

I will change the code ASAP when somethings bugging or the I messed up with the style guidelines.

@lassevonpfeil
Copy link
ContributorAuthor

Added no tests btw. Works bug-free on MacOS 15.6 and should work universally.

@lassevonpfeillassevonpfeil changed the title New links in "Help" menu for issues and forum #1208 New links in "Help" menu for issues and forum Aug 15, 2025
@SableRafSableRaf requested a review from catilacAugust 20, 2025 11:43
Copy link
Collaborator

@catilaccatilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Great work on this! I am curious about which version of Java you are using. We use Eclipse Temurin 17. I believe if you set that SDK then you will see that desktop.browse() will throw an exception.

here is an example in the file of the pattern you'll want to follow:

item = newJMenuItem(Language.text("menu.help.getting_started")); item.addActionListener(e -> Platform.openURL(Language.text("menu.help.getting_started.url"))); menu.add(item);

Copy link
ContributorAuthor

@lassevonpfeillassevonpfeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed used method to Platform.openURL(). Should now work universally.

Comment on lines 39 to 41
importjava.net.URI;
importjava.net.URISyntaxException;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these necessary anymore? If not please remove, and then this is ready to be approved! 🎉

Copy link
ContributorAuthor

@lassevonpfeillassevonpfeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, removed the imports now. I personally think it looks good now. But of course I would love to make some changes if needed.

Copy link
Collaborator

@catilaccatilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@catilaccatilac merged commit e02ef2e into processing:mainAug 22, 2025
6 checks passed

// Ask on the Forum link opener
item = newJMenuItem(Language.text("menu.help.ask"));
item.addActionListener(e -> Platform.openURL(Language.text("menu.help.getting_started.url")));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lassevonpfeil. I just caught while testing: the URL here should have been menu.help.ask.url instead of menu.help.getting_started.url. Would you mind making another PR for this small fix? Thanks! cc @catilac

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lassevonpfeil just checking in. Would you be able to confirm whether or not you'll be able to make this small PR?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for the delay. Of course, will work on it asap.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem at all! Just wanted to check in. Thank you so much, @lassevonpfeil :)

catilac added a commit that referenced this pull request Aug 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lassevonpfeil@catilac@SableRaf