Fix syntax highlighting for short and Short types#1260
Merged
+1 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
catilac requested changes Oct 7, 2025
Collaborator
catilac left a comment
catilac left a comment There was a problem hiding this comment.
I don't believe that we currently support the Short datatype. Can you remove the Short keyword addition?
Everything else works.
As for Short: You are welcome to create an issue around supporting the Short class. It will take more effort than adding a keyword to keywords.txt
ContributorAuthor
aj-m commented Oct 8, 2025
Done. I assumed it made sense to add |
catilac approved these changes Oct 8, 2025
Collaborator
catilac commented Oct 8, 2025
Thank you so much @aj-m! That is a totally understandable assumption to make. Approved 🎉 🙌🏽 |
catilac merged commit 5dc52be into processing:main 6 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
catilac commented Oct 8, 2025
@all-contributors please add @aj-m for code |
Contributor
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #1259
Changes:
shortandShortkeywords so they're correctly highlighted as datatypes.Tests: I don't think they apply here, but it looks and runs right for me.
