General cleanup of Base#1299
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I started cleaning up some of `Base`'s startup sequence for clarity of what is being started when. Nowhere near completion and I think a lot of this class will need to be refactored in the future. Also removed some of the timing measurement comments Added some comments to the Processing CLI class
Stefterv commented Oct 22, 2025
| // // Check if there were previously opened sketches to be restored | ||
| // boolean opened = restoreSketches(); | ||
| ContributionListingcl = ContributionListing.getInstance(); |
CollaboratorAuthor
There was a problem hiding this comment.
This is one thing that moved in the sequence, I think this should be okay
Collaborator
There was a problem hiding this comment.
what is contribution listing?
CollaboratorAuthor
There was a problem hiding this comment.
It's the helper class that will gather the contributions in the contributions manager from the net
Stefterv commented Oct 22, 2025
| privatestaticvoidsetLookAndFeel(){ | ||
| try{ | ||
| // Use native popups to avoid looking crappy on macOS | ||
| JPopupMenu.setDefaultLightWeightPopupEnabled(false); |
CollaboratorAuthor
There was a problem hiding this comment.
Also moved in the sequence
Stefterv merged commit 2955cb2 into processing:main 6 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started cleaning up some of
Base's startup sequence for clarity of what is being started when. Nowhere near completion and I think a lot of this class will need to be refactored in the future.Also removed some of the timing measurement comments
Added some comments to the Processing CLI class